Handle broken symlinks in devcontainer set up#5250
Open
Conversation
dylanjew
force-pushed
the
dylanj/symlink
branch
from
46ffdb9 to
d1f9041
Compare
aakallam
approved these changes
Apr 21, 2026
| os.symlink(src, target) | ||
|
|
||
| assert os.path.exists(target), f'Failed to create {target} symlink for {src}.' | ||
| assert os.path.lexists(target), f'Failed to create {target} symlink for {src}.' |
Collaborator
There was a problem hiding this comment.
I get changing to lexists for the cleanup method but shouldn't we catch here if the symlink is broken?
Collaborator
Author
There was a problem hiding this comment.
makes sense! done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was running into an issue running the server in the devcontainer when I had initialized the config on my host machine.
This PR cleans up broken symlinks correctly
After this change I can run the server in the devcontainer and the symlink is fixed